]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
vstart_runner.py: set omit_sudo's default value to False
authorRishabh Dave <ridave@redhat.com>
Tue, 17 Sep 2019 12:00:51 +0000 (17:30 +0530)
committerRishabh Dave <ridave@redhat.com>
Wed, 6 Nov 2019 06:06:10 +0000 (11:36 +0530)
This shouldn't be an inconvenience since default value for omit_sudo is
already False in teuthology's codebase.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
qa/tasks/vstart_runner.py

index bc95a450e3f6e0d0478f009d410383bcaa23d525..f35fb8a4a414e4ed0ebed5e1dbba8c730353f006 100644 (file)
@@ -318,7 +318,7 @@ class LocalRemote(object):
 
     def run(self, args, check_status=True, wait=True,
             stdout=None, stderr=None, cwd=None, stdin=None,
-            logger=None, label=None, env=None, timeout=None, omit_sudo=True):
+            logger=None, label=None, env=None, timeout=None, omit_sudo=False):
         args = self._perform_checks_and_return_list_of_args(args, omit_sudo)
 
         # We have to use shell=True if any run.Raw was present, e.g. &&
@@ -507,7 +507,8 @@ class LocalKernelMount(KernelMount):
         else:
             return keyring_path
 
-    def run_shell(self, args, wait=True, stdin=None, check_status=True, omit_sudo=True):
+    def run_shell(self, args, wait=True, stdin=None, check_status=True,
+                  omit_sudo=False):
         # FIXME maybe should add a pwd arg to teuthology.orchestra so that
         # the "cd foo && bar" shenanigans isn't needed to begin with and
         # then we wouldn't have to special case this
@@ -546,7 +547,7 @@ class LocalKernelMount(KernelMount):
                                       check_status=check_status,
                                       omit_sudo=False)
 
-    def testcmd(self, args, wait=True, stdin=None, omit_sudo=True):
+    def testcmd(self, args, wait=True, stdin=None, omit_sudo=False):
         # FIXME maybe should add a pwd arg to teuthology.orchestra so that
         # the "cd foo && bar" shenanigans isn't needed to begin with and
         # then we wouldn't have to special case this