mgr/dashboard: annotate command handler

and use enum as the argument

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/pybind/mgr/dashboard/plugins/debug.py b/src/pybind/mgr/dashboard/plugins/debug.py
index 6106143f5f89068b1ee15b9b820f6b2ce8c8753f..8eb2bb1e6da08c0dd419dda4a0fa234ce7182061 100644 (file)
--- a/src/pybind/mgr/dashboard/plugins/debug.py
+++ b/src/pybind/mgr/dashboard/plugins/debug.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+
 from __future__ import absolute_import
 
 import json
@@ -55,14 +56,14 @@ class Debug(SP, I.CanCherrypy, I.ConfiguresCherryPy,  # pylint: disable=too-many
         self._refresh_health_checks()
 
     @no_type_check
-    def handler(self, action):
+    def handler(self, action: Actions):
         '''
         Control and report debug status in Ceph-Dashboard
         '''
         ret = 0
         msg = ''
-        if action in [Actions.ENABLE.value, Actions.DISABLE.value]:
-            self.set_option(self.NAME, action == Actions.ENABLE.value)
+        if action in [Actions.ENABLE, Actions.DISABLE]:
+            self.set_option(self.NAME, action == Actions.ENABLE)
             self.mgr.update_cherrypy_config({})
             self._refresh_health_checks()
         else:
@@ -73,8 +74,6 @@ class Debug(SP, I.CanCherrypy, I.ConfiguresCherryPy,  # pylint: disable=too-many
     COMMANDS = [
         SP.Command(
             prefix="dashboard {name}".format(name=NAME),
-            args="name=action,type=CephChoices,strings={states}".format(
-                states="|".join(a.value for a in Actions)),
             handler=handler
         )
     ]