]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: RbdMirroringService test suite fails in dev mode 25865/head
authorStephan Müller <smueller@suse.com>
Wed, 9 Jan 2019 12:49:14 +0000 (13:49 +0100)
committerStephan Müller <smueller@suse.com>
Thu, 10 Jan 2019 14:31:51 +0000 (15:31 +0100)
If you have set DEV in unit-test-configuration.ts to true, in order to
run all unit tests much faster, the unit test suite of rbd mirroring
service fails.

The reason is, that it's expecting a call, that is triggered inside the
constructor, which is only done once in for the copy used in the fast
testing mode (if it would be done on within ngOnInit this wouldn't be a
problem).

Fixes: http://tracker.ceph.com/issues/37841
Signed-off-by: Stephan Müller <smueller@suse.com>
src/pybind/mgr/dashboard/frontend/src/app/shared/api/rbd-mirroring.service.spec.ts

index 905c5110bdafd527afd7a597e276491773a762b0..6432e187ce33f01a730ddcd75dcdb22803960737 100644 (file)
@@ -19,10 +19,13 @@ describe('RbdMirroringService', () => {
     }
   };
 
-  configureTestBed({
-    providers: [RbdMirroringService],
-    imports: [HttpClientTestingModule]
-  });
+  configureTestBed(
+    {
+      providers: [RbdMirroringService],
+      imports: [HttpClientTestingModule]
+    },
+    true
+  );
 
   beforeEach(() => {
     service = TestBed.get(RbdMirroringService);