]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
src/pybind/mgr/cephadm/service_discovery: fixed HAProxy labels 62299/head
authorBernard Landon <bernard@lndn.ch>
Thu, 13 Mar 2025 11:04:42 +0000 (11:04 +0000)
committerBernard Landon <bernard@lndn.ch>
Thu, 12 Jun 2025 14:27:03 +0000 (14:27 +0000)
Fixes: https://tracker.ceph.com/issues/70477
Signed-off-by: Bernard Landon <bernard@lndn.ch>
src/pybind/mgr/cephadm/service_discovery.py
src/pybind/mgr/cephadm/tests/test_service_discovery.py

index 867a5ff39f12bd7bcf9323637c95164f45c4c4ed..31e8423725a3d4082f064e56d29f96b9b8b822f0 100644 (file)
@@ -228,7 +228,7 @@ class Root(Server):
                     addr = self.mgr.inventory.get_addr(dd.hostname)
                     srv_entries.append({
                         'targets': [f"{build_url(host=addr, port=spec.monitor_port).lstrip('/')}"],
-                        'labels': {'instance': dd.service_name()}
+                        'labels': {'ingress': dd.service_name(), 'instance': dd.hostname}
                     })
         return srv_entries
 
index d1203c54c04eb4ffd8609ea807cd07d2a751f6bb..7723b2c1aae628728a2acaa4166923c37246a559 100644 (file)
@@ -170,7 +170,8 @@ class TestServiceDiscovery:
 
         # check content
         assert cfg[0]['targets'] == ['1.2.3.4:9049']
-        assert cfg[0]['labels'] == {'instance': 'ingress'}
+        assert cfg[0]['labels'] == {'instance': 'node0', 'ingress': 'ingress'}
+        assert cfg[1]['labels'] == {'instance': 'node1', 'ingress': 'ingress'}
 
     def test_get_sd_config_ceph_exporter(self):
         mgr = FakeMgr()