]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph_argparse.py: fix dangerous default value [] as arg
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Thu, 11 Jul 2013 14:04:07 +0000 (16:04 +0200)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Thu, 11 Jul 2013 14:04:07 +0000 (16:04 +0200)
Fix valid pylint warning about "Dangerous default value [] as argument".

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/pybind/ceph_argparse.py

index e2a486e877601596442b4f58f0e89e3c2ba21a9b..5fce3140dad4d0a223f7ba552fb58b10dcfd816c 100644 (file)
@@ -879,7 +879,7 @@ def validate_command(parsed_args, sigdict, args, verbose=False):
 
         return valid_dict
 
-def send_command(cluster, target=('mon', ''), cmd=[], inbuf='', timeout=0, 
+def send_command(cluster, target=('mon', ''), cmd=None, inbuf='', timeout=0, 
                  verbose=False):
     """
     Send a command to a daemon using librados's
@@ -892,6 +892,7 @@ def send_command(cluster, target=('mon', ''), cmd=[], inbuf='', timeout=0,
 
     If target is osd.N, send command to that osd (except for pgid cmds)
     """
+    cmd = cmd or []
     try:
         if target[0] == 'osd':
             osdid = target[1]