]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/mgr: mgr_test_case: raise SkipTest instead of calling skipTest() 38165/head
authorRishabh Dave <ridave@redhat.com>
Mon, 9 Nov 2020 11:02:39 +0000 (16:32 +0530)
committerRishabh Dave <ridave@redhat.com>
Wed, 18 Nov 2020 14:37:17 +0000 (20:07 +0530)
skipTest() is being used as a class method which is not correct since
it's an instance method. Replace call to skipTest() by a raising
SkipTest instead.

Fixes: https://tracker.ceph.com/issues/48152
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit eb70274fa2c8d341585c21a274c91f9328c97a72)

qa/tasks/mgr/mgr_test_case.py

index 37baeb20e41f8643633c732aab1f9d88f9ac6653..8687b5f29002026de39709cbf9354b35f871248e 100644 (file)
@@ -1,6 +1,8 @@
 import json
 import logging
 
+from unittest import SkipTest
+
 from teuthology import misc
 from tasks.ceph_test_case import CephTestCase
 
@@ -99,7 +101,7 @@ class MgrTestCase(CephTestCase):
         assert cls.mgr_cluster is not None
 
         if len(cls.mgr_cluster.mgr_ids) < cls.MGRS_REQUIRED:
-            cls.skipTest(
+            raise SkipTest(
                 "Only have {0} manager daemons, {1} are required".format(
                     len(cls.mgr_cluster.mgr_ids), cls.MGRS_REQUIRED))