client: clear I_COMPLETE on traceless reply for dentry request

If a request is against a dentry, and we get a traceless reply, clear
the directory I_COMPLETE flag on the parent directory because we can no
longer trust that our cache is complete.

It is possible we could do something a bit more intelligent here, but it
is not trivial because of racing requests, and traceless replies are
rare, so it's not worth the effort.

Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/client/Client.cc b/src/client/Client.cc
index b3bea7adcbcd5cfe0a06e4d11d186dd3d219305f..6497558008ddf0fa7df9a505338fdeb57d776eb1 100644 (file)
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -903,6 +903,14 @@ Inode* Client::insert_trace(MetaRequest *request, int mds)
   bufferlist::iterator p = reply->get_trace_bl().begin();
   if (p.end()) {
     ldout(cct, 10) << "insert_trace -- no trace" << dendl;
+
+    if (request->dentry &&
+       request->dentry->dir &&
+       (request->dentry->dir->parent_inode->flags & I_COMPLETE)) {
+      ldout(cct, 10) << " clearing I_COMPLETE on " << *request->dentry->dir->parent_inode << dendl;
+      request->dentry->dir->parent_inode->flags &= ~I_COMPLETE;
+      request->dentry->dir->release_count++;
+    }
     return NULL;
   }