common: Passing null pointer option_name to operator << in md_config_t::parse_option()

Fixes the Coverity Scan Report:
CID 1412776 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)19. var_deref_model: Passing null pointer option_name to operator <<, which dereferences it.

Fixed the review comments too in this commit.

Signed-off-by: Jos Collin <jcollin@redhat.com>

diff --git a/src/common/config.cc b/src/common/config.cc
index 8c026f89a9ffdcdd789dc39a88953b15ed5233c2..5065f4a141dff69e8dc1242a881638f4fc0cf3a7 100644 (file)
--- a/src/common/config.cc
+++ b/src/common/config.cc
@@ -603,6 +603,7 @@ int md_config_t::parse_option(std::vector<const char*>& args,
   }
 
   if (ret != 0 || !error_message.empty()) {
+    assert(option_name);
     if (oss) {
       *oss << "Parse error setting " << option_name << " to '"
            << val << "' using injectargs";