]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: do not include unused header 64181/head
authorKefu Chai <tchaikov@gmail.com>
Wed, 25 Jun 2025 13:51:04 +0000 (21:51 +0800)
committerKefu Chai <tchaikov@gmail.com>
Wed, 25 Jun 2025 13:53:10 +0000 (21:53 +0800)
previously, when building cls_rgw, we could have following build
failure:

```
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/cls/rgw/cls_rgw_types.cc:4:
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/cls/rgw/cls_rgw_types.h:15:
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/rgw/rgw_basic_types.h:32:
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/rgw/rgw_user_types.h:27:
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/dout.h:29:
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/ceph_context.h:41:
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/config_proxy.h:7:
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/config.h:28:
In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/config_values.h:59:
/home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/options/legacy_config_opts.h:1:10: fatal error: 'global_legacy_options.h' file not found
    1 | #include "global_legacy_options.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
```

but it turned out that `cls_rgw_types.h` does not use `dout.h` at all.
so, in this change, we just drop this include. this helps to reduce
the build dependency.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
src/rgw/rgw_user_types.h

index 2329eca3d60e0fce485f39e183262f4ad68000f3..b731269e9cf28ffba5c90c19fa0246dfc65f2757 100644 (file)
@@ -24,7 +24,6 @@
 #include <variant>
 #include <fmt/format.h>
 
-#include "common/dout.h"
 #include "common/Formatter.h"
 
 // strong typedef to std::string