]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/MonCommands: improve "osd pool create" command validation
authorKefu Chai <kchai@redhat.com>
Tue, 24 Sep 2019 07:04:56 +0000 (15:04 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 24 Sep 2019 07:07:28 +0000 (15:07 +0800)
both `expected_num_objects` and `size` are required to be greater or
equal to 0, and monitor will return -EINVAL at seeing a negative value
of either of them. so let's fail earlier.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/mon/MonCommands.h

index 273b019914d5b4fc74d3ee997dcc6cf14e242a7e..e188f197d2c9a77e550692c90f754352eb60da97 100644 (file)
@@ -1022,8 +1022,8 @@ COMMAND("osd pool create " \
         "name=pool_type,type=CephChoices,strings=replicated|erasure,req=false " \
        "name=erasure_code_profile,type=CephString,req=false,goodchars=[A-Za-z0-9-_.] " \
        "name=rule,type=CephString,req=false " \
-        "name=expected_num_objects,type=CephInt,req=false " \
-        "name=size,type=CephInt,req=false " \
+        "name=expected_num_objects,type=CephInt,range=0,req=false " \
+        "name=size,type=CephInt,range=0,req=false " \
        "name=pg_num_min,type=CephInt,range=0,req=false " \
        "name=target_size_bytes,type=CephInt,range=0,req=false " \
        "name=target_size_ratio,type=CephFloat,range=0|1,req=false",\