]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
build/ops: unify command substitution in install-deps.sh
authorNathan Cutler <ncutler@suse.com>
Wed, 1 Aug 2018 10:33:58 +0000 (12:33 +0200)
committerNathan Cutler <ncutler@suse.com>
Fri, 4 Oct 2019 09:20:03 +0000 (11:20 +0200)
The $() form is preferable to `` because folks (like me) might be using
` as a keyboard shortcut to GNU Screen, causing havoc to ensue whenever
copy-pasting the ` character.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit e0042dd617269934bf51efee5bab7e4485875576)

install-deps.sh

index c092a0a2cab7fdc51d95ae9161a495994678e753..18b6a8ea8103a66b029325dc8e9d3cbc34333627 100755 (executable)
@@ -21,7 +21,7 @@ if test $(id -u) != 0 ; then
 fi
 export LC_ALL=C # the following is vulnerable to i18n
 
-ARCH=`uname -m`
+ARCH=$(uname -m)
 
 function munge_ceph_spec_in {
     # http://rpm.org/user_doc/conditional_builds.html
@@ -118,7 +118,7 @@ EOF
     fi
 }
 
-if [ x`uname`x = xFreeBSDx ]; then
+if [ x$(uname)x = xFreeBSDx ]; then
     $SUDO pkg install -yq \
         devel/babeltrace \
         devel/git \