]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/os: mark dtor of interface class "virtual"
authorKefu Chai <kchai@redhat.com>
Tue, 6 Oct 2020 11:03:38 +0000 (19:03 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 6 Oct 2020 14:22:25 +0000 (22:22 +0800)
we use a smart_ptr in Seastore to manage the life cycle of
`TransactionManager` which is in turn a subclass
`ExtentCallbackInterface`, so should declare the dtor of latter as
virtual.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/os/seastore/segment_cleaner.h

index c4943a1590f7e7306306b3bdf803c6aed0640af8..43a2897ca050517ae767c7e8bcf651e06e51e99e 100644 (file)
@@ -37,6 +37,7 @@ public:
   /// Callback interface for querying and operating on segments
   class ExtentCallbackInterface {
   public:
+    virtual ~ExtentCallbackInterface() = default;
     /**
      * get_next_dirty_extent
      *