mds: avoid assert after suicide()

Fixes: #5079
Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/mds/MDCache.cc b/src/mds/MDCache.cc
index 094aefdf5563067efe6cb633c2838cc3fcba6f60..cc661f214860a6366d07c7b959bd5138dc3ca37f 100644 (file)
--- a/src/mds/MDCache.cc
+++ b/src/mds/MDCache.cc
@@ -5653,9 +5653,11 @@ void MDCache::_recovered(CInode *in, int r, uint64_t size, utime_t mtime)
 
   if (r != 0) {
     dout(0) << "recovery error! " << r << dendl;
-    if (r == -EBLACKLISTED)
+    if (r == -EBLACKLISTED) {
       mds->suicide();
-    assert(0);
+      return;
+    }
+    assert(0 == "unexpected error from osd during recovery");
   }
 
   file_recovering.erase(in);