]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/MDSMonitor: add note about missing metadata inclusion
authorPatrick Donnelly <pdonnell@redhat.com>
Fri, 3 May 2024 00:49:22 +0000 (20:49 -0400)
committerPatrick Donnelly <pdonnell@redhat.com>
Tue, 7 May 2024 12:19:28 +0000 (08:19 -0400)
There is a "client_count" metadata on the health warning that apparently was
intended to be used for aggregating warnings but never was. Add a TODO item for
that.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
src/mon/MDSMonitor.cc

index ab1257566eb2b4cbfd0baea0e37864e3736eea81..357f944df21aefd6920286a4167ab1e82ff04313 100644 (file)
@@ -313,6 +313,7 @@ void MDSMonitor::encode_pending(MonitorDBStore::TransactionRef t)
   }
   pending.get_health_checks(&new_checks);
   for (auto& p : new_checks.checks) {
+    // TODO: handle "client_count" metadata when summarizing
     p.second.summary = std::regex_replace(
       p.second.summary,
       std::regex("%num%"),