]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
os/ObjectStore: pass by ref to clone
authorSage Weil <sage@redhat.com>
Mon, 28 Nov 2016 19:26:21 +0000 (14:26 -0500)
committerSage Weil <sage@redhat.com>
Mon, 28 Nov 2016 19:29:14 +0000 (14:29 -0500)
CID 1395658 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
pass_by_value: Passing parameter noid of type ghobject_t (size 144 bytes) by value.

Signed-off-by: Sage Weil <sage@redhat.com>
src/os/ObjectStore.h

index 35e1026685c9cc5f6b741e9638f25b3fc4169eeb..3bbce7555607e40c66ca2c3acf165ce7c3f3099c 100644 (file)
@@ -1156,7 +1156,8 @@ public:
      * The destination named object may already exist, in
      * which case its previous contents are discarded.
      */
-    void clone(const coll_t& cid, const ghobject_t& oid, ghobject_t noid) {
+    void clone(const coll_t& cid, const ghobject_t& oid,
+              const ghobject_t& noid) {
       Op* _op = _get_next_op();
       _op->op = OP_CLONE;
       _op->cid = _get_coll_id(cid);