]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/admin: do not validate params of ConfigSetHook 36443/head
authorKefu Chai <kchai@redhat.com>
Tue, 4 Aug 2020 07:28:00 +0000 (15:28 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 4 Aug 2020 07:28:47 +0000 (15:28 +0800)
validate_cmd() should have taken care of this

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/admin/admin_socket.cc

index 5c3da6fa5d1761ae8480ffa753e5b4afd667eccf..6d0011489df079e6a111fc752a70ecceacc9d0dc 100644 (file)
@@ -488,11 +488,8 @@ public:
   {
     std::string var;
     std::vector<std::string> new_val;
-    if (!cmd_getval(cmdmap, "var", var) ||
-        !cmd_getval(cmdmap, "val", new_val)) {
-      return seastar::make_ready_future<tell_result_t>(
-        tell_result_t{-EINVAL, "syntax error: 'config set <var> <value>'"});
-    }
+    cmd_getval(cmdmap, "var", var);
+    cmd_getval(cmdmap, "val", new_val);
     // val may be multiple words
     const std::string joined_values = boost::algorithm::join(new_val, " ");
     return local_conf().set_val(var, joined_values).then([format] {