cls_lock_client: return error when decoding fails

Library code shouldn't be using cerr either.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>

diff --git a/src/cls/lock/cls_lock_client.cc b/src/cls/lock/cls_lock_client.cc
index c7893afce2bba50fa735d331b9987b5c20c34939..d693431f716e74f18ff3915b83dafba07a1a07d3 100644 (file)
--- a/src/cls/lock/cls_lock_client.cc
+++ b/src/cls/lock/cls_lock_client.cc
@@ -117,7 +117,7 @@ namespace rados {
         try {
           ::decode(ret, iter);
         } catch (buffer::error& err) {
-          cerr << __func__ << ": failed to decode response" << std::endl;
+         return -EBADMSG;
         }
 
         *locks = ret.locks;
@@ -143,7 +143,7 @@ namespace rados {
         try {
           ::decode(ret, iter);
         } catch (buffer::error& err) {
-          cerr << __func__ << ": failed to decode response" << std::endl;
+         return -EBADMSG;
         }
 
         if (lockers) {