]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/tasks/ceph.py: cleanup: stop calling get_wwn_id_map()
authorNathan Cutler <ncutler@suse.com>
Tue, 22 Oct 2019 13:42:48 +0000 (15:42 +0200)
committerNathan Cutler <ncutler@suse.com>
Fri, 27 Mar 2020 23:34:47 +0000 (00:34 +0100)
Nowadays, get_wwn_id_map is essentially a noop - it does:

    return dict((d, d) for d in devs)

This reverts another bit of 8f720454cbb536ac6f410fb6c18b2b0945b70160 from 2013.

References: https://tracker.ceph.com/issues/42313
Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 51c714d9b29402f21b25b5754d42f917964079e2)

qa/tasks/ceph.py

index 5000198ee0d4a10ffc4deb4a832cddd491770212..338722dc9e838f4f4eb83018d121e6186cc31b7d 100644 (file)
@@ -604,19 +604,17 @@ def cluster(ctx, config):
         if config.get('fs'):
             log.info('fs option selected, checking for scratch devs')
             log.info('found devs: %s' % (str(devs),))
-            devs_id_map = teuthology.get_wwn_id_map(remote, devs)
-            iddevs = list(devs_id_map.values())
             roles_to_devs = assign_devs(
-                teuthology.cluster_roles_of_type(roles_for_host, 'osd', cluster_name), iddevs
+                teuthology.cluster_roles_of_type(roles_for_host, 'osd', cluster_name), devs
             )
-            if len(roles_to_devs) < len(iddevs):
-                iddevs = iddevs[len(roles_to_devs):]
+            if len(roles_to_devs) < len(devs):
+                devs = devs[len(roles_to_devs):]
             devs_to_clean[remote] = []
 
         if config.get('block_journal'):
             log.info('block journal enabled')
             roles_to_journals = assign_devs(
-                teuthology.cluster_roles_of_type(roles_for_host, 'osd', cluster_name), iddevs
+                teuthology.cluster_roles_of_type(roles_for_host, 'osd', cluster_name), devs
             )
             log.info('journal map: %s', roles_to_journals)