]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: report error
authorYehuda Sadeh <yehuda@redhat.com>
Fri, 4 Dec 2015 01:02:16 +0000 (17:02 -0800)
committerYehuda Sadeh <yehuda@redhat.com>
Fri, 12 Feb 2016 00:13:42 +0000 (16:13 -0800)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
src/rgw/rgw_coroutine.cc

index a91c7333ded16c6cd354f239d76658ab571b47b4..1acfd50f5d8e7ab9a1c557e12ef9874fd2582e93 100644 (file)
@@ -350,6 +350,9 @@ bool RGWCoroutinesStack::unblock_stack(RGWCoroutinesStack **s)
 
 void RGWCoroutinesManager::report_error(RGWCoroutinesStack *op)
 {
+  if (!op) {
+    return;
+  }
 #warning need to have error logging infrastructure that logs on backend
   lderr(cct) << "ERROR: failed operation: " << op->error_str() << dendl;
 }
@@ -692,7 +695,7 @@ bool RGWCoroutine::drain_children(int num_cr_left)
         if (ret < 0) {
           ldout(cct, 0) << "ERROR: collect() returned error" << dendl;
           /* we should have reported this error */
-#warning deal with error
+          log_error() << "ERROR: collect() returned error (ret=" << ret << ")";
         }
       }
     }