]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
tools/ceph_objectstore_tool: handle fsck and fsck-deep op in unified path
authorxie xingguo <xie.xingguo@zte.com.cn>
Wed, 2 Nov 2016 01:19:15 +0000 (09:19 +0800)
committerxie xingguo <xie.xingguo@zte.com.cn>
Wed, 2 Nov 2016 01:19:15 +0000 (09:19 +0800)
https://github.com/ceph/ceph/pull/11724/commits/181e28ba999c4134957f04183bad5c4dfc0e7062
introduces too much code redundancy, this patch simplifies it a little.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
src/tools/ceph_objectstore_tool.cc

index c25b5218c41e0e2b9bcb83d32cafdc0255556a86..ab1ae81dc808bdf4465bf208b0e47f2e60fee235 100644 (file)
@@ -2594,21 +2594,8 @@ int main(int argc, char **argv)
     myexit(1);
   }
 
-  if (op == "fsck") {
-    int r = fs->fsck(false);
-    if (r < 0) {
-      cerr << "fsck failed: " << cpp_strerror(r) << std::endl;
-      myexit(1);
-    }
-    if (r > 0) {
-      cerr << "fsck found " << r << " errors" << std::endl;
-      myexit(1);
-    }
-    cout << "fsck found no errors" << std::endl;
-    exit(0);
-  }
-  if (op == "fsck-deep") {
-    int r = fs->fsck(true);
+  if (op == "fsck" || op == "fsck-deep") {
+    int r = fs->fsck(op == "fsck-deep");
     if (r < 0) {
       cerr << "fsck failed: " << cpp_strerror(r) << std::endl;
       myexit(1);