mgr/smb: remove unused generate_smb_service_spec function

Remove the generate_smb_service_spec as it was unused (it was used
early on for a debug dump command). Leaving it would have meant
keeping it up-to-date with the real spec generating function and
unnecessary extra work.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit b624222df09ef2831ba1679090168a121ae30bd6)

diff --git a/src/pybind/mgr/smb/handler.py b/src/pybind/mgr/smb/handler.py
index 11e95c9ad18a7a2e750c836f0e3205e96d94c9bb..ff43f4a6c18ac8cf171f62a7cccb5cf8db5a5156 100644 (file)
--- a/src/pybind/mgr/smb/handler.py
+++ b/src/pybind/mgr/smb/handler.py
@@ -625,35 +625,6 @@ class ClusterConfigHandler:
             _cephx_data_entity(cluster_id),
         )
 
-    def generate_smb_service_spec(self, cluster_id: str) -> SMBSpec:
-        """Demo function that generates a smb service spec on demand."""
-        cluster = self._cluster_entry(cluster_id).get_cluster()
-        # if the user manually puts custom configurations (aka "override"
-        # configs) in the store, use that in favor of the generated config.
-        # this is mainly intended for development/test
-        config_entries = [
-            self.public_store[external.config_key(cluster_id)],
-            self.public_store[external.config_key(cluster_id, override=True)],
-        ]
-        join_source_entries = [
-            self.priv_store[(cluster_id, key)]
-            for key in external.stored_join_source_keys(
-                self.priv_store, cluster_id
-            )
-        ]
-        user_source_entries = [
-            self.priv_store[(cluster_id, key)]
-            for key in external.stored_usergroup_source_keys(
-                self.priv_store, cluster_id
-            )
-        ]
-        return _generate_smb_service_spec(
-            cluster,
-            config_entries=config_entries,
-            join_source_entries=join_source_entries,
-            user_source_entries=user_source_entries,
-        )
-
 
 def order_resources(
     resource_objs: Iterable[SMBResource],