]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: Use std::cmp_greater to avoid signedness warnings.
authorAlex Ainscow <aainscow@uk.ibm.com>
Tue, 15 Jul 2025 10:50:20 +0000 (11:50 +0100)
committerAlex Ainscow <aainscow@uk.ibm.com>
Sun, 7 Sep 2025 23:10:41 +0000 (00:10 +0100)
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
(cherry picked from commit 846879e6c2ec4ab5a65040981a617f4b603c379a)

src/osd/ECTransaction.cc

index 9f2a02d78a811baf3dd9b1e52eca24394cae79a1..13c2428b94a49e35b8137e40c6fafa74fd44189b 100644 (file)
@@ -608,7 +608,7 @@ ECTransaction::Generate::Generate(PGTransaction &t,
    * not simply construct written shards here.
    */
   for (auto &&[shard, t] : transactions) {
-    if (t.get_num_ops() > old_transaction_counts[int(shard)] &&
+    if (std::cmp_greater(t.get_num_ops(), old_transaction_counts[int(shard)]) &&
         !entry->is_written_shard(shard)) {
       ldpp_dout(dpp, 20) << __func__ << " Transaction for shard " << shard << ": ";
       Formatter *f = Formatter::create("json");