]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: fix end check in Server::handle_client_readdir()
authorYan, Zheng <zheng.z.yan@intel.com>
Fri, 11 Jan 2013 07:46:59 +0000 (15:46 +0800)
committerYan, Zheng <zheng.z.yan@intel.com>
Mon, 28 Jan 2013 02:18:15 +0000 (10:18 +0800)
commit 1174dd3188 (don't retry readdir request after issuing caps)
introduced an bug that wrongly marks 'end' in the the readdir reply.
The code that touches existing dentries re-uses an iterator, and the
iterator is used for checking if readdir is end.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
src/mds/Server.cc

index b70445e9a1db557196f12126e1125fe7de31f05c..45eed81c6ac8c707f2a1fd4146936063c775bf2b 100644 (file)
@@ -2895,11 +2895,9 @@ void Server::handle_client_readdir(MDRequest *mdr)
        continue;
       } else {
        // touch everything i _do_ have
-       for (it = dir->begin(); 
-            it != dir->end(); 
-            it++) 
-         if (!it->second->get_linkage()->is_null())
-           mdcache->lru.lru_touch(it->second);
+       for (CDir::map_t::iterator p = dir->begin(); p != dir->end(); p++)
+         if (!p->second->get_linkage()->is_null())
+           mdcache->lru.lru_touch(p->second);
 
        // already issued caps and leases, reply immediately.
        if (dnbl.length() > 0) {