rgw: fix xml parser leak

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
(cherry picked from commit f86522cdfcd81b2d28c581ac8b8de6226bc8d1a4)

diff --git a/src/rgw/rgw_xml.cc b/src/rgw/rgw_xml.cc
index 1d95abcb4b6d247e092438fe19597de41826d06f..ae5b4bbfd977f7b3c66d96c4d160104c438156c1 100644 (file)
--- a/src/rgw/rgw_xml.cc
+++ b/src/rgw/rgw_xml.cc
@@ -133,11 +133,14 @@ static void xml_start(void *data, const char *el, const char **attr) {
 RGWXMLParser::
 RGWXMLParser() : buf(NULL), buf_len(0), cur_obj(NULL), success(true)
 {
+  p = XML_ParserCreate(NULL);
 }
 
 RGWXMLParser::
 ~RGWXMLParser()
 {
+  XML_ParserFree(p);
+
   free(buf);
   vector<XMLObj *>::iterator iter;
   for (iter = objs.begin(); iter != objs.end(); ++iter) {
@@ -194,7 +197,6 @@ void RGWXMLParser::handle_data(const char *s, int len)
 
 bool RGWXMLParser::init()
 {
-  p = XML_ParserCreate(NULL);
   if (!p) {
     return false;
   }
@@ -219,8 +221,5 @@ bool RGWXMLParser::parse(const char *_buf, int len, int done)
     success = false;
   }
 
-  if (done || !success)
-    XML_ParserFree(p);
-
   return success;
 }