]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
unittest_ecbackend: fix signed/unsigned warnings
authorSage Weil <sage@inktank.com>
Sun, 23 Feb 2014 06:00:55 +0000 (22:00 -0800)
committerSage Weil <sage@inktank.com>
Sun, 23 Feb 2014 06:00:55 +0000 (22:00 -0800)
In file included from test/osd/TestECBackend.cc:20:0:
../src/gtest/include/gtest/gtest.h: In instantiation of ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int]’:
../src/gtest/include/gtest/gtest.h:1300:30: required from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int; bool lhs_is_null_literal = false]’
test/osd/TestECBackend.cc:30:281: required from here
warning: ../src/gtest/include/gtest/gtest.h:1263:3: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by: Sage Weil <sage@inktank.com>
src/test/osd/TestECBackend.cc

index 11bb53b555bebf8cde858d7e78a0070d187ca291..affff369442ae320a47443ece2a1b6e57c8353ce 100644 (file)
@@ -27,17 +27,17 @@ TEST(ECUtil, stripe_info_t)
   ECUtil::stripe_info_t s(ssize, swidth);
   ASSERT_EQ(s.get_stripe_width(), swidth);
 
-  ASSERT_EQ(s.logical_to_next_chunk_offset(0), 0);
+  ASSERT_EQ(s.logical_to_next_chunk_offset(0), 0u);
   ASSERT_EQ(s.logical_to_next_chunk_offset(1), s.get_chunk_size());
   ASSERT_EQ(s.logical_to_next_chunk_offset(swidth - 1),
            s.get_chunk_size());
 
-  ASSERT_EQ(s.logical_to_prev_chunk_offset(0), 0);
+  ASSERT_EQ(s.logical_to_prev_chunk_offset(0), 0u);
   ASSERT_EQ(s.logical_to_prev_chunk_offset(swidth), s.get_chunk_size());
   ASSERT_EQ(s.logical_to_prev_chunk_offset((swidth * 2) - 1),
            s.get_chunk_size());
 
-  ASSERT_EQ(s.logical_to_next_stripe_offset(0), 0);
+  ASSERT_EQ(s.logical_to_next_stripe_offset(0), 0u);
   ASSERT_EQ(s.logical_to_next_stripe_offset(swidth - 1),
            s.get_stripe_width());