]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
cmake: let vstart-base depend on cython_rados if NOT WIN32 41728/head
authorKefu Chai <kchai@redhat.com>
Mon, 7 Jun 2021 08:00:23 +0000 (16:00 +0800)
committerKefu Chai <kchai@redhat.com>
Mon, 7 Jun 2021 08:02:20 +0000 (16:02 +0800)
to disable this custom target if NOT WIN32 without explanations is difficult
to maintain, so add a comment, and limit the scope to just
`cython_rados`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/CMakeLists.txt

index ed69b15fbef47561afc8370d58e049e4340f7bf2..73b3279505c63d2ec689298edfecf300b8282427 100644 (file)
@@ -891,7 +891,6 @@ configure_file(
   ${CMAKE_BINARY_DIR}/include/acconfig.h
 )
 
-if(NOT WIN32)
 # Everything you need to spin up a cluster with vstart.sh
 add_custom_target(vstart-base DEPENDS
     ceph-osd
@@ -900,8 +899,14 @@ add_custom_target(vstart-base DEPENDS
     ceph-conf
     monmaptool
     crushtool
-    rados
+    rados)
+if(NOT WIN32)
+  # WIN32 port does not build python bindings
+  # TODO: introduce an option for enabling python binding
+  add_dependencies(vstart-base
     cython_rados)
+endif()
+
 if (WITH_MGR)
   add_dependencies(vstart-base ceph-mgr)
 endif()
@@ -928,7 +933,6 @@ endif()
 if(WITH_MGR)
   add_dependencies(vstart ceph-volume-venv-setup)
 endif()
-endif(NOT WIN32)
 
 # Everything you need to run CephFS tests
 add_custom_target(cephfs_testing DEPENDS