mon/OSDMonitor: fix rmsnap command

```
There are 2 ways to remove pool snaps, rados tool or mon command (ceph osd pool rmsnap).
It seems that the monitor command is not reporting the actual removal via new_removed_snaps which is later proceed in OSDMap::apply_incremental.
This will result in a clone object leakage since the snap id won't be marked as purged (and won't be trimmed).
```

Fixes: https://tracker.ceph.com/issues/64646
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit f19ad233025957964559410e6697aa8a2a024bc1)

diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
index 917e9c47d45e25e8b5f2426dfa53ccb020a30d01..23c4f2832b35fc0816e8ab6dc2fe2e568d42f982 100644 (file)
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@ -13084,6 +13084,7 @@ bool OSDMonitor::prepare_command_impl(MonOpRequestRef op,
     if (sn) {
       pp->remove_snap(sn);
       pp->set_snap_epoch(pending_inc.epoch);
+      pending_inc.new_removed_snaps[pool].insert(sn);
       ss << "removed pool " << poolstr << " snap " << snapname;
     } else {
       ss << "already removed pool " << poolstr << " snap " << snapname;