]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-volume: delete test_lvs_list_is_created_just_once
authorRishabh Dave <ridave@redhat.com>
Fri, 6 Dec 2019 07:40:35 +0000 (13:10 +0530)
committerJan Fajerski <jfajerski@suse.com>
Fri, 28 Feb 2020 10:50:40 +0000 (11:50 +0100)
lisitng.py doesn't call api.Volumes anymore. Therefore, this test is
redundant.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 665ed2424b7bef4160289f0135acc015f8ea9980)

src/ceph-volume/ceph_volume/tests/devices/lvm/test_listing.py

index bd460cc0e817ddd3540cb86bcac2493e81ecdeb5..0ca6992203f28e6cc966774a69400f3fec7e4e56 100644 (file)
@@ -86,24 +86,6 @@ class TestList(object):
         with pytest.raises(SystemExit):
             lvm.listing.List([]).list(args)
 
-    def test_lvs_list_is_created_just_once(self, monkeypatch, is_root, volumes, factory):
-        api.volumes_obj_create_count = 0
-
-        def monkey_populate(self):
-            api.volumes_obj_create_count += 1
-            for lv_item in api.get_api_lvs():
-                self.append(api.Volume(**lv_item))
-        monkeypatch.setattr(api.Volumes, '_populate', monkey_populate)
-
-        args = factory(format='pretty', device='/dev/sda1')
-        with pytest.raises(SystemExit):
-            lvm.listing.List([]).list(args)
-
-        # XXX: Ideally, the count should be just 1. Volumes._populate() is
-        # being called thrice out of which only twice is moneky_populate.
-        assert api.volumes_obj_create_count == 2
-
-
 class TestFullReport(object):
 
     def test_no_ceph_lvs(self, volumes, monkeypatch):