src/vstart.sh: fix start_ganesha() to avoid crashing nfs-ganesha server

inclusion of "allow_set_io_flusher_fail = true" is needed otherwise the service won't start cause of EPERM,
referencing cephadm commit http://github.com/ceph/ceph/commit/3e3b7fa8ea22a2dd7f5d5c97d6e096a5e30585f4 which
does the same. Also, ensure double quotes around some config options like RecoveryBackend, some options in
RADOS_KV block and some in RADOS_URLS.

Fixes: https://tracker.ceph.com/issues/76407
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

diff --git a/src/vstart.sh b/src/vstart.sh
index 27bd1502268823dfbf5defd0b89b3ba9cfc3fcf7..b478c00b090513268fd90e31a0af872b01aeada8 100755 (executable)
--- a/src/vstart.sh
+++ b/src/vstart.sh
@@ -1582,6 +1582,7 @@ start_ganesha() {
             Enable_RQUOTA = false;
             Protocols = 4;
             NFS_Port = $port;
+            allow_set_io_flusher_fail = true;
         }
 
         MDCACHE {
@@ -1589,20 +1590,20 @@ start_ganesha() {
         }
 
         NFSv4 {
-           RecoveryBackend = rados_cluster;
+           RecoveryBackend = "\"rados_cluster\"";
            Minor_Versions = 1, 2;
         }
 
         RADOS_KV {
-           pool = '$pool_name';
-           namespace = $namespace;
-           UserId = $test_user;
+           pool = "\"$pool_name\"";
+           namespace = "\"$namespace\"";
+           UserId = "\"$test_user\"";
            nodeid = $name;
         }
 
         RADOS_URLS {
-          Userid = $test_user;
-          watch_url = '$url';
+          Userid = "\"$test_user\"";
+          watch_url = "\"$url\"";
         }
 
        %url $url" > "$ganesha_dir/ganesha-$name.conf"