]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: fix 'this->ondisk_version' will always evaluate to 'true' 38674/head
authorMark Kogan <mkogan@redhat.com>
Mon, 21 Dec 2020 11:36:16 +0000 (13:36 +0200)
committerMark Kogan <mkogan@redhat.com>
Mon, 21 Dec 2020 11:36:16 +0000 (13:36 +0200)
fix:
```
src/rgw/CMakeFiles/radosgw.dir/rgw_rest_metadata.cc.o
../src/rgw/rgw_rest_metadata.cc:267:13: warning: address of
'this->ondisk_version' will always evaluate to 'true'
[-Wpointer-bool-conversion]
                                       &ondisk_version);
```
Fixes: https://tracker.ceph.com/issues/48688
Signed-off-by: Mark Kogan <mkogan@redhat.com>
src/rgw/rgw_rest_metadata.cc

index 9f6392202853e2b6390c5d91a7e0c9a789981b8f..795382dbc91d8f2d0617ed6ce470be06d60c2993 100644 (file)
@@ -264,7 +264,7 @@ void RGWOp_Metadata_Put::execute(optional_yield y) {
   }
 
   op_ret = store->ctl()->meta.mgr->put(metadata_key, bl, s->yield, sync_type,
-                                      &ondisk_version);
+                                      false, &ondisk_version);
   if (op_ret < 0) {
     dout(5) << "ERROR: can't put key: " << cpp_strerror(op_ret) << dendl;
     return;