]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: make note about osd df calc bug 4335/head
authorSage Weil <sage@redhat.com>
Tue, 14 Apr 2015 16:35:04 +0000 (09:35 -0700)
committerSage Weil <sage@redhat.com>
Tue, 14 Apr 2015 16:35:04 +0000 (09:35 -0700)
Signed-off-by: Sage Weil <sage@redhat.com>
src/mon/OSDMonitor.cc

index 5c5ecaed58a6286b2893ee3c46eadd5fb793093f..7d8513b7df088ee8f5f6eee2f887f68dbd6a5aac 100644 (file)
@@ -625,6 +625,11 @@ public:
     max_var(-1),
     stddev(0),
     sum(0) {
+    // FIXME: average_util should be calculated from the same set of
+    // nodes that dump_item considers when calculating the stddev.  we
+    // probably need to make two tree traversals for that to work,
+    // maybe with a callback like precalc_item() that's looks similar
+    // to dump_item()?
     if (pgm->osd_sum.kb)
       average_util = 100.0 * (double)pgm->osd_sum.kb_used / (double)pgm->osd_sum.kb;
   }