tools/rados: silence clang++ warning

ceph/src/tools/rados/rados.cc:1951:47: warning: moving a temporary
object prevents copy elision [-Wpessimizing-move]
  boost::optional<pg_t> pgid(i != opts.end(), std::move(pg_t()));
                                              ^
ceph/src/tools/rados/rados.cc:1951:47: note: remove std::move
call here
  boost::optional<pg_t> pgid(i != opts.end(), std::move(pg_t()));

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/tools/rados/rados.cc b/src/tools/rados/rados.cc
index cb4eae2742a6d230d0a4b4f3287522ac909e2969..d7d6ae0ec1d9884c6c54e3b8a1eb990600df0660 100644 (file)
--- a/src/tools/rados/rados.cc
+++ b/src/tools/rados/rados.cc
@@ -1948,7 +1948,7 @@ static int rados_tool_common(const std::map < std::string, std::string > &opts,
   }
 
   i = opts.find("pgid");
-  boost::optional<pg_t> pgid(i != opts.end(), std::move(pg_t()));
+  boost::optional<pg_t> pgid(i != opts.end(), pg_t());
   if (pgid && (!pgid->parse(i->second.c_str()) || (pool_name && rados.pool_lookup(pool_name) != pgid->pool()))) {
     cerr << "invalid pgid" << std::endl;
     ret = -1;