]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: helpful warning in 'health detail' output about incomplete pgs
authorSage Weil <sage@inktank.com>
Tue, 13 Nov 2012 21:25:50 +0000 (13:25 -0800)
committerSage Weil <sage@inktank.com>
Tue, 13 Nov 2012 23:12:33 +0000 (15:12 -0800)
Signed-off-by: Sage Weil <sage@inktank.com>
src/mon/PGMonitor.cc

index 14b97df97bb9da516f2160cde0c6bdcaf7b72a7c..f8d311235ceae3fb4ac6e9985c0bd4935c393a9b 100644 (file)
@@ -1291,6 +1291,13 @@ void PGMonitor::get_health(list<pair<health_status_t,string> >& summary,
          ss << ", acting " << p->second.acting;
          if (p->second.stats.sum.num_objects_unfound)
            ss << ", " << p->second.stats.sum.num_objects_unfound << " unfound";
+         if (p->second.state & PG_STATE_INCOMPLETE) {
+           const pg_pool_t *pi = mon->osdmon()->osdmap.get_pg_pool(p->first.pool());
+           if (pi && pi->min_size > 1) {
+             ss << " (reducing pool " << mon->osdmon()->osdmap.get_pool_name(p->first.pool())
+                << " min_size from " << (int)pi->min_size << " may help; search ceph.com/docs for 'incomplete')";
+           }
+         }
          detail->push_back(make_pair(HEALTH_WARN, ss.str()));
        }
       }