]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
common/options.cc, doc: osd_snap_trim_sleep overrides other variants 29678/head
authorNeha Ojha <nojha@redhat.com>
Fri, 28 Jun 2019 16:53:01 +0000 (09:53 -0700)
committerPrashant D <pdhange@redhat.com>
Thu, 15 Aug 2019 00:55:30 +0000 (20:55 -0400)
A value > 0 for osd_snap_trim_sleep, will override the backend specific
variants of osd_snap_trim_sleep.

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 733df09fe5111e7beca75f8be0afb8669ef9a625)

doc/rados/configuration/osd-config-ref.rst
src/common/options.cc

index 0530010c910f916ed94498a6f99545102cc4dc99..200cd52b6f44c08d243179f004d77c0fd455163a 100644 (file)
@@ -473,6 +473,7 @@ Operations
 
 :Description: Time in seconds to sleep before next snap trim op.
               Increasing this value will slow down snap trimming.
+              This option overrides backend specific variants.
 
 :Type: Float
 :Default: ``0``
index 16fb1144c36db5d85892f99bf440e4f429d2acb2..2ce73b5e3c7ea3704e87c2c6c8d6b1e78cef3bd4 100644 (file)
@@ -3305,7 +3305,7 @@ std::vector<Option> get_global_options() {
 
     Option("osd_snap_trim_sleep", Option::TYPE_FLOAT, Option::LEVEL_ADVANCED)
     .set_default(0)
-    .set_description("Time in seconds to sleep before next snap trim"),
+    .set_description("Time in seconds to sleep before next snap trim (overrides values below)"),
 
     Option("osd_snap_trim_sleep_hdd", Option::TYPE_FLOAT, Option::LEVEL_ADVANCED)
     .set_default(5)