]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
cephfs-journal-tool: disambiguate usage of all keyword (in tool help). 53645/head
authorManish M Yathnalli <manish.yathnalli@komprise.com>
Wed, 21 Jun 2023 07:59:41 +0000 (13:29 +0530)
committerVenky Shankar <vshankar@redhat.com>
Mon, 25 Sep 2023 09:41:03 +0000 (15:11 +0530)
        The fs:all for rank option description was confusing. It seemd
like the fs was optional, but it is mandatory. This change modifies the
help message to reflect the correct way to use all in the --rank option.

Fixes: https://tracker.ceph.com/issues/61753
Signed-off-by: Manish M Yathnalli <myathnal@redhat.com>
(cherry picked from commit 52c033f85e274c86bd75f0eb902a32d86356094e)

src/tools/cephfs/JournalTool.cc

index ec98609803a46a3998f44efae380440a2f9592aa..0836ee8b3d2c36491af18a102141f23772dc9ae4 100644 (file)
@@ -62,7 +62,7 @@ void JournalTool::usage()
     << "    <output>: [summary|list|binary|json] [--path <path>]\n"
     << "\n"
     << "General options:\n"
-    << "  --rank=filesystem:mds-rank|all Journal rank (mandatory)\n"
+    << "  --rank=filesystem:{mds-rank|all} journal rank or \"all\" ranks (mandatory)\n"
     << "  --journal=<mdlog|purge_queue>  Journal type (purge_queue means\n"
     << "                                 this journal is used to queue for purge operation,\n"
     << "                                 default is mdlog, and only mdlog support event mode)\n"