]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/cephfs: mark file system joinable for fs rename tests before unmounting clients
authorVenky Shankar <vshankar@redhat.com>
Wed, 22 May 2024 10:14:47 +0000 (06:14 -0400)
committerVenky Shankar <vshankar@redhat.com>
Thu, 23 May 2024 05:01:06 +0000 (01:01 -0400)
Fixes: http://tracker.ceph.com/issues/66088
Signed-off-by: Venky Shankar <vshankar@redhat.com>
qa/tasks/cephfs/test_admin.py

index 18d5ba01bf7d7b97d05ccff5d6198cb0b8061ea1..d7d2fd8148dcb549dbb9515246092321b9d78cf8 100644 (file)
@@ -839,9 +839,6 @@ class TestRenameCommand(TestAdminCommands):
         """
         That renaming a non-existent file system fails.
         """
-        self.skipTest('This test is broken ATM; see '
-                      'https://tracker.ceph.com/issues/66088')
-
         self.run_ceph_cmd(f'fs fail {self.fs.name}')
         self.run_ceph_cmd(f'fs set {self.fs.name} refuse_client_session true')
         sleep(5)
@@ -851,6 +848,9 @@ class TestRenameCommand(TestAdminCommands):
             self.assertEqual(ce.exitstatus, errno.ENOENT, "invalid error code on renaming a non-existent fs")
         else:
             self.fail("expected renaming of a non-existent file system to fail")
+        self.run_ceph_cmd(f'fs set {self.fs.name} joinable true')
+        self.fs.wait_for_daemons()
+        self.run_ceph_cmd(f'fs set {self.fs.name} refuse_client_session false')
 
     def test_fs_rename_fails_new_name_already_in_use(self):
         """