]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/PGMap: 'unclean' does not imply damaged
authorSage Weil <sage@redhat.com>
Mon, 23 Oct 2017 21:07:48 +0000 (16:07 -0500)
committerDavid Zafman <dzafman@redhat.com>
Tue, 23 Jan 2018 18:03:13 +0000 (10:03 -0800)
Everything (that I can think of) that would lead to a PG being unclean is
already reported via another health message.  And there are cases where a
PG is unclean (e.g., because it is backfilling) where we are not degraded.

Fix by ignoring this flag in the health checks.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 89e4cb90af3c193fe436390b5e3288701e6fc4af)

src/mon/PGMap.cc

index 6fcc3c0721afba4ba79cfc83ea15d6e2cffaeeab..a09caa4c813991cd5d0bab28377867b013f5f625 100644 (file)
@@ -2672,8 +2672,7 @@ void PGMap::get_health_checks(
     { PG_STATE_UNDERSIZED,       {DEGRADED,    [](const pg_stat_t &p){return p.last_fullsized;} } },
     { PG_STATE_STALE,            {UNAVAILABLE, [](const pg_stat_t &p){return p.last_unstale;}   } },
     // Delayed and inverted reports
-    { PG_STATE_ACTIVE,           {UNAVAILABLE, [](const pg_stat_t &p){return p.last_active;}, true} },
-    { PG_STATE_CLEAN,            {DEGRADED,    [](const pg_stat_t &p){return p.last_clean;}, true} }
+    { PG_STATE_ACTIVE,           {UNAVAILABLE, [](const pg_stat_t &p){return p.last_active;}, true} }
   };
 
   // Specialized state printer that takes account of inversion of