]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/cephfs: set omit_sudo False when sudo is set to True 46165/head
authorRishabh Dave <ridave@redhat.com>
Thu, 5 May 2022 14:25:16 +0000 (19:55 +0530)
committerRishabh Dave <ridave@redhat.com>
Thu, 5 May 2022 14:33:28 +0000 (20:03 +0530)
In these methods, parameter "sudo" indicates whether or not sudo is set
to True but the same is not indicated to methods underneath. This value
needs to be passed for the parameter to fulfill it's commitment.

Fixes: https://tracker.ceph.com/issues/55557
Signed-off-by: Rishabh Dave <ridave@redhat.com>
qa/tasks/cephfs/mount.py
qa/tasks/vstart_runner.py

index c0855bbc17173e75bd395d905536e7d7825ffafd..1c98d7c3c867331a632ee6216a74901be87a1afb 100644 (file)
@@ -693,7 +693,8 @@ class CephFSMount(object):
         if sudo:
             args.append('sudo')
         args += ['adjust-ulimits', 'daemon-helper', 'kill', py_version, '-c', pyscript]
-        return self.client_remote.run(args=args, wait=False, stdin=run.PIPE, stdout=StringIO())
+        return self.client_remote.run(args=args, wait=False, stdin=run.PIPE,
+                                      stdout=StringIO(), omit_sudo=(not sudo))
 
     def run_python(self, pyscript, py_version='python3', sudo=False):
         p = self._run_python(pyscript, py_version, sudo=sudo)
index 7fa426acdf459d1929cbd615155dedcd36a94578..4ce36fdff08ffa6e20a4f74ea902c02f9a35e3e6 100644 (file)
@@ -683,8 +683,8 @@ class LocalCephFSMount():
         if sudo:
             args.append('sudo')
         args += [py_version, '-c', pyscript]
-        return self.client_remote.run(args=args,
-                                      wait=False, stdout=StringIO())
+        return self.client_remote.run(args=args, wait=False,
+                                      stdout=StringIO(), omit_sudo=(not sudo))
 
     def setup_netns(self):
         if opt_use_ns: