crimson/osd: use finally for capturing this

* no need to capture this, it is already enclosed by `ref`
* use finally for capturing `ref`, and for printing out the "complete"
  logging message. we could use a different branch for printing out
  the failure message if any.

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/crimson/osd/osd_operations/peering_event.cc b/src/crimson/osd/osd_operations/peering_event.cc
index 2372adb328eb0a8116cd7718c721d7f72b063915..aa3fdec2155c21229475e22650207a8dbc885ce0 100644 (file)
--- a/src/crimson/osd/osd_operations/peering_event.cc
+++ b/src/crimson/osd/osd_operations/peering_event.cc
@@ -90,8 +90,8 @@ seastar::future<> PeeringEvent::start()
     }
   }).then([this] {
     return shard_services.send_pg_temp();
-  }).then([this, ref=std::move(ref)] {
-    logger().debug("{}: complete", *this);
+  }).finally([ref=std::move(ref)] {
+    logger().debug("{}: complete", *ref);
   });
 }