]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: add assert to lock path
authorSage Weil <sage@inktank.com>
Sat, 29 Sep 2012 08:17:21 +0000 (01:17 -0700)
committerSage Weil <sage@inktank.com>
Sat, 29 Sep 2012 08:17:21 +0000 (01:17 -0700)
This makes coverity happy:

CID 716916: Explicit null dereferenced (FORWARD_NULL)
At (28): Passing null pointer "in" to function "MDSCacheObject::state_test(unsigned int) const", which dereferences it. [hide details]

Signed-off-by: Sage Weil <sage@inktank.com>
src/mds/Locker.cc

index 72802ea7e7c60a9a6521cf26ba830a762f5f17e2..a03789f23685afc9413a31be18e08ed9cb1afe43 100644 (file)
@@ -606,6 +606,7 @@ void Locker::eval_gather(SimpleLock *lock, bool first, bool *pneed_issue, list<C
            << " on " << *lock->get_parent() << dendl;
 
     if (lock->get_sm() == &sm_filelock) {
+      assert(in);
       if (in->state_test(CInode::STATE_NEEDSRECOVER)) {
        dout(7) << "eval_gather finished gather, but need to recover" << dendl;
        mds->mdcache->queue_file_recover(in);