common: have read_secret_from_file return negative error codes

Allow the caller to try to determine what happened.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit 496aa3f91bc21c087db3268860563402095d596a)

diff --git a/src/common/secret.c b/src/common/secret.c
index 8f92fb0a7f01bce100e69c6f99be4369cbe55abe..83fcf10df51daec7c00e82a65e88096cf3840fb2 100644 (file)
--- a/src/common/secret.c
+++ b/src/common/secret.c
@@ -31,13 +31,13 @@ int read_secret_from_file(const char *filename, char *secret, size_t max_len)
   fd = open(filename, O_RDONLY);
   if (fd < 0) {
     perror("unable to read secretfile");
-    return -1;
+    return -errno;
   }
   len = safe_read(fd, secret, max_len);
   if (len <= 0) {
     perror("unable to read secret from file");
     close(fd);
-    return -1;
+    return len ? len : -ENODATA;
   }
   end = secret;
   while (end < secret + len && *end && *end != '\n' && *end != '\r')