]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: don't track change of config 'mds_replay_unsafe_with_closed_session' 37360/head
authorYan, Zheng <zyan@redhat.com>
Mon, 17 Aug 2020 04:55:22 +0000 (12:55 +0800)
committerNathan Cutler <ncutler@suse.com>
Wed, 23 Sep 2020 12:30:24 +0000 (14:30 +0200)
the option is only used when mds is recovering.

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 3a8e22527357da1c5b701a22915288e398e7b93c)

Conflicts:
src/mds/MDSRank.cc
- octopus does not have "mds_heartbeat_grace" in
  MDSRankDispatcher::get_tracked_conf_keys KEYS array

src/common/options.cc
src/mds/MDSRank.cc
src/mds/Server.cc

index f76a623149472867515b343e10ce1c47aec74d50..71cdcd7f3c9c1e18c199e16182e2cd6ab4db1bd3 100644 (file)
@@ -7831,7 +7831,7 @@ std::vector<Option> get_mds_options() {
 
     Option("mds_replay_unsafe_with_closed_session", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
     .set_default(false)
-    .set_flag(Option::FLAG_RUNTIME)
+    .set_flag(Option::FLAG_STARTUP)
     .set_description("complete all the replay request when mds is restarted, no matter the session is closed or not"),
 
     Option("mds_default_dir_hash", Option::TYPE_INT, Option::LEVEL_ADVANCED)
index e7ebee467e7acf7534b22dd696619c5d1b4c521a..41621585df70bb416bb8557d2dfe29d43213424d 100644 (file)
@@ -3577,7 +3577,6 @@ const char** MDSRankDispatcher::get_tracked_conf_keys() const
     "mds_recall_warning_decay_rate",
     "mds_request_load_average_decay_rate",
     "mds_session_cache_liveness_decay_rate",
-    "mds_replay_unsafe_with_closed_session",
     NULL
   };
   return KEYS;
index ed06fe22b5f3ce7e5276a8bbeef7838a62cef398..1857583af0478bdc65bc81d91bbd36b977194ede 100644 (file)
@@ -1158,9 +1158,6 @@ void Server::handle_conf_change(const std::set<std::string>& changed) {
   if (changed.count("mds_forward_all_requests_to_auth")){
     forward_all_requests_to_auth = g_conf().get_val<bool>("mds_forward_all_requests_to_auth");
   }
-  if (changed.count("mds_replay_unsafe_with_closed_session")) {
-    replay_unsafe_with_closed_session = g_conf().get_val<bool>("mds_replay_unsafe_with_closed_session");
-  }
   if (changed.count("mds_cap_revoke_eviction_timeout")) {
     cap_revoke_eviction_timeout = g_conf().get_val<double>("mds_cap_revoke_eviction_timeout");
     dout(20) << __func__ << " cap revoke eviction timeout changed to "