test/crimson/seastore: add a random overwrite test to test_objec_date_handler

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

diff --git a/src/crimson/os/seastore/async_cleaner.cc b/src/crimson/os/seastore/async_cleaner.cc
index d7e398f5f732ad03b0e684fbaeb1e38af7423d6a..fd043f4ea35e67eaa9f3a00e6fa7879875b5953c 100644 (file)
--- a/src/crimson/os/seastore/async_cleaner.cc
+++ b/src/crimson/os/seastore/async_cleaner.cc
@@ -388,7 +388,7 @@ JournalTrimmerImpl::config_t::get_test(
     max_journal_bytes = 4 * roll_size;
   } else {
     assert(type == journal_type_t::RANDOM_BLOCK);
-    target_dirty_bytes = roll_size / 4;
+    target_dirty_bytes = roll_size / 36;
     target_alloc_bytes = roll_size / 4;
     max_journal_bytes = roll_size / 2;
   }

diff --git a/src/test/crimson/seastore/test_object_data_handler.cc b/src/test/crimson/seastore/test_object_data_handler.cc
index ae44cb94a62d79bd8cc91a20d218fa08045317f5..d054fc18f4804e47d86c6fa4ab78486c996c1db4 100644 (file)
--- a/src/test/crimson/seastore/test_object_data_handler.cc
+++ b/src/test/crimson/seastore/test_object_data_handler.cc
@@ -110,12 +110,17 @@ struct object_data_handler_test_t:
 
   bufferptr known_contents;
   extent_len_t size = 0;
+  std::random_device rd;
+  std::mt19937 gen;
 
-  object_data_handler_test_t() {}
+  object_data_handler_test_t() : gen(rd()) {}
 
   void write(Transaction &t, objaddr_t offset, extent_len_t len, char fill) {
     ceph_assert(offset + len <= known_contents.length());
     size = std::max<extent_len_t>(size, offset + len);
+    Option::size_t olen = crimson::common::local_conf().get_val<Option::size_t>(
+      "seastore_data_delta_based_overwrite");
+    ceph_assert(olen == 0 || len <= olen);
     memset(
       known_contents.c_str() + offset,
       fill,
@@ -233,12 +238,18 @@ struct object_data_handler_test_t:
   }
 
   void set_overwrite_threshold() {
-    crimson::common::local_conf().set_val("seastore_data_delta_based_overwrite", "131072").get();
+    crimson::common::local_conf().set_val("seastore_data_delta_based_overwrite",
+      "16777216").get();
   }
   void unset_overwrite_threshold() {
     crimson::common::local_conf().set_val("seastore_data_delta_based_overwrite", "0").get();
   }
 
+  laddr_t get_random_laddr(size_t block_size, laddr_t limit) {
+    return block_size *
+      std::uniform_int_distribution<>(0, (limit / block_size) - 1)(gen);
+  }
+
   void test_multi_write() {
     write((1<<20) - (4<<10), 4<<10, 'a');
     write(1<<20, 4<<10, 'b');
@@ -671,6 +682,38 @@ TEST_P(object_data_handler_test_t, multiple_overwrite) {
   });
 }
 
+TEST_P(object_data_handler_test_t, random_overwrite) {
+  constexpr size_t TOTAL = 4<<20;
+  constexpr size_t BSIZE = 4<<10;
+  constexpr size_t BLOCKS = TOTAL / BSIZE;
+  run_async([this] {
+    set_overwrite_threshold();
+    size_t wsize = std::uniform_int_distribution<>(10, BSIZE - 1)(gen);
+    uint8_t div[3] = {1, 2, 4};
+    uint8_t block_num = div[std::uniform_int_distribution<>(0, 2)(gen)];
+    for (unsigned i = 0; i < BLOCKS / block_num; ++i) {
+      auto t = create_mutate_transaction();
+      write(i * (BSIZE * block_num), BSIZE * block_num, 'a');
+    }
+
+    for (unsigned i = 0; i < 4; ++i) {
+      for (unsigned j = 0; j < 100; ++j) {
+       auto t = create_mutate_transaction();
+       for (unsigned k = 0; k < 2; ++k) {
+         write(*t, get_random_laddr(BSIZE, TOTAL), wsize,
+           (char)((j*k) % std::numeric_limits<char>::max()));
+       }
+       submit_transaction(std::move(t));
+      }
+      restart();
+      epm->check_usage();
+      logger().info("random_writes: {} done replaying/checking", i);
+    }
+    read(0, 4<<20);
+    unset_overwrite_threshold();
+  });
+}
+
 INSTANTIATE_TEST_SUITE_P(
   object_data_handler_test,
   object_data_handler_test_t,