]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
client: avoid second lock on client_lock 21554/head
authorSupriti Singh <supriti.singh@suse.com>
Fri, 20 Apr 2018 07:48:53 +0000 (09:48 +0200)
committerSupriti Singh <supriti.singh@suse.com>
Mon, 23 Apr 2018 13:52:10 +0000 (15:52 +0200)
Avoid a second nested lock on client lock. As a result, drop unused function ll_get_inodeno().
Fixes: https://tracker.ceph.com/issues/23815
Signed-off-by: Supriti Singh <supriti.singh@suse.com>
src/client/Client.cc
src/client/Client.h

index 9f82607609b90757728c58ec6300d00b3ede8b42..ace425d2a0a86e8093c868da717888b952d6062c 100644 (file)
@@ -12424,7 +12424,7 @@ int Client::ll_get_stripe_osd(Inode *in, uint64_t blockno,
 {
   Mutex::Locker lock(client_lock);
 
-  inodeno_t ino = ll_get_inodeno(in);
+  inodeno_t ino = in->ino;
   uint32_t object_size = layout->object_size;
   uint32_t su = layout->stripe_unit;
   uint32_t stripe_count = layout->stripe_count;
index e24e4454c1b04ebb5b47be887e8ea5ad8913b005..fe6e066c6f46a7c3565b2c200b7c77ae25b38d66 100644 (file)
@@ -1131,11 +1131,6 @@ public:
   int get_caps_issued(int fd);
   int get_caps_issued(const char *path, const UserPerm& perms);
 
-  // low-level interface v2
-  inodeno_t ll_get_inodeno(Inode *in) {
-    Mutex::Locker lock(client_lock);
-    return _get_inodeno(in);
-  }
   snapid_t ll_get_snapid(Inode *in);
   vinodeno_t ll_get_vino(Inode *in) {
     Mutex::Locker lock(client_lock);