]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/OSDMonitor.cc: cannot set target_size_ratio to negative
authorKamoltat <ksirivad@redhat.com>
Fri, 4 Mar 2022 16:18:45 +0000 (16:18 +0000)
committerKamoltat <ksirivad@redhat.com>
Tue, 15 Mar 2022 17:59:32 +0000 (17:59 +0000)
Throw an error when user set `target_size_ratio`
to negative using the command:

`osd pool set <pool> target_size_ratio <float>`

Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit 1b882054ba386d026a27fcd4f3b9f38e75a531cb)

src/mon/OSDMonitor.cc

index b01dc4b72ebb7ec48466e9b6ab3d6a0fc349dff5..e1b1c9ff4c6bd1611286ada5ee08122b7f74ce60 100644 (file)
@@ -8814,6 +8814,11 @@ int OSDMonitor::prepare_command_pool_set(const cmdmap_t& cmdmap,
            << "later before setting target_size_bytes";
         return -EINVAL;
       }
+    } else if (var == "target_size_ratio") {
+      if (f < 0.0) {
+       ss << "target_size_ratio cannot be negative";
+       return -EINVAL;
+      }
     } else if (var == "pg_num_min") {
       if (interr.length()) {
         ss << "error parsing int value '" << val << "': " << interr;