crush/CrushWrapper: behave with empty weight vector

should not dereference an empty vector.

Fixes: https://tracker.ceph.com/issues/43404
Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/crush/CrushWrapper.h b/src/crush/CrushWrapper.h
index 979705460384272d65b384f3714553e48614149e..8e3ceee48f664206de08a35e25770c0cdc07c7fa 100644 (file)
--- a/src/crush/CrushWrapper.h
+++ b/src/crush/CrushWrapper.h
@@ -1577,8 +1577,9 @@ public:
     crush_init_workspace(crush, work);
     crush_choose_arg_map arg_map = choose_args_get_with_fallback(
       choose_args_index);
-    int numrep = crush_do_rule(crush, rule, x, rawout, maxout, &weight[0],
-                              weight.size(), work, arg_map.args);
+    int numrep = crush_do_rule(crush, rule, x, rawout, maxout,
+                              std::data(weight), std::size(weight),
+                              work, arg_map.args);
     if (numrep < 0)
       numrep = 0;
     out.resize(numrep);