ceph-detect-init: return None at seeing unknown debian distro

* return None at seeing unknown debian distros
* add test for this accordingly

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/ceph-detect-init/ceph_detect_init/debian/__init__.py b/src/ceph-detect-init/ceph_detect_init/debian/__init__.py
index 2c0cdb8ef3246f1437398b34342c4bf0d298f572..73a7851a3fc9ab21d3c8ad73f0c94aa630358250 100644 (file)
--- a/src/ceph-detect-init/ceph_detect_init/debian/__init__.py
+++ b/src/ceph-detect-init/ceph_detect_init/debian/__init__.py
@@ -14,9 +14,8 @@ def choose_init():
             return 'systemd'
         else:
             return 'upstart'
-    if distro.lower() in ('debian'):
+    if distro.lower() == 'debian':
         if codename in ('squeeze', 'wheezy'):
             return 'sysvinit'
         else:
             return 'systemd'
-    return 'sysvinit'

diff --git a/src/ceph-detect-init/tests/test_all.py b/src/ceph-detect-init/tests/test_all.py
index f444eebb9f791c2054e36947f7929dffa74f0d8e..c13b12b7364d4e230d35a91f83b344337d991641 100644 (file)
--- a/src/ceph-detect-init/tests/test_all.py
+++ b/src/ceph-detect-init/tests/test_all.py
@@ -48,6 +48,10 @@ class TestCephDetectInit(testtools.TestCase):
                                  distro='debian',
                                  codename='wheezy'):
             self.assertEqual('sysvinit', debian.choose_init())
+        with mock.patch.multiple('ceph_detect_init.debian',
+                                 distro='debian',
+                                 codename='jessie'):
+            self.assertEqual('systemd', debian.choose_init())
         with mock.patch.multiple('ceph_detect_init.debian',
                                  distro='ubuntu',
                                  codename='trusty'):
@@ -56,6 +60,10 @@ class TestCephDetectInit(testtools.TestCase):
                                  distro='ubuntu',
                                  codename='vivid'):
             self.assertEqual('systemd', debian.choose_init())
+        with mock.patch.multiple('ceph_detect_init.debian',
+                                 distro='not-debian',
+                                 codename='andy'):
+            self.assertIs(None, debian.choose_init())
 
     def test_fedora(self):
         with mock.patch('ceph_detect_init.fedora.release',