]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/smb: use is comparisions for enum values
authorJohn Mulligan <jmulligan@redhat.com>
Wed, 18 Sep 2024 22:28:46 +0000 (15:28 -0700)
committerJohn Mulligan <jmulligan@redhat.com>
Tue, 24 Sep 2024 17:39:42 +0000 (13:39 -0400)
Use `is` based comparisions for two enum related functions as mypy likes
this better.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
src/pybind/mgr/smb/enums.py

index dea45f951f831ca5e3ae43bc7bf3411b2d58c657..3e8544f43cf5a5b70c067855c892c6c149ba1a74 100644 (file)
@@ -21,7 +21,7 @@ class CephFSStorageProvider(_StrEnum):
 
     def expand(self) -> 'CephFSStorageProvider':
         """Expand abbreviated/default values into the full/expanded form."""
-        if self == self.SAMBA_VFS:
+        if self is self.SAMBA_VFS:
             # mypy gets confused by enums
             return self.__class__(self.SAMBA_VFS_NEW)
         return self
@@ -89,9 +89,9 @@ class LoginAccess(_StrEnum):
     def expand(self) -> 'LoginAccess':
         """Exapend abbreviated enum values into their full forms."""
         # the extra LoginAccess(...) calls are to appease mypy
-        if self == self.READ_ONLY_SHORT:
+        if self is self.READ_ONLY_SHORT:
             return LoginAccess(self.READ_ONLY)
-        if self == self.READ_WRITE_SHORT:
+        if self is self.READ_WRITE_SHORT:
             return LoginAccess(self.READ_WRITE)
         return self