]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
os/bluestore: Small fix to check_or_set_bdev_label
authorAdam Kupczyk <akupczyk@ibm.com>
Tue, 30 Jan 2024 17:45:14 +0000 (17:45 +0000)
committerAdam Kupczyk <akupczyk@ibm.com>
Mon, 22 Jul 2024 12:28:50 +0000 (12:28 +0000)
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
src/os/bluestore/BlueStore.cc
src/os/bluestore/BlueStore.h

index 6a137637bebc741fdb5166859238798267d1bdde..2ae3dc5502728e1739c33e5a316ab688e86cefd9 100644 (file)
@@ -6776,7 +6776,7 @@ void BlueStore::_main_bdev_label_remove(Allocator* an_alloc)
 }
 
 int BlueStore::_check_or_set_bdev_label(
-  string path, uint64_t size, string desc, bool create)
+  const string& path, uint64_t size, string desc, bool create)
 {
   bluestore_bdev_label_t label;
   if (create) {
@@ -6804,7 +6804,7 @@ int BlueStore::_check_or_set_bdev_label(
 }
 
 int BlueStore::_check_or_set_main_bdev_label(
-  string path, uint64_t size, bool create)
+  const string& path, uint64_t size, bool create)
 {
   if (create) {
     bdev_label_valid_locations.clear();
index fdc3d5a53c53a93d823720d1fa44cd4b5112702b..599bd42f317adae2b72cbcbe66c9224fc73be080 100644 (file)
@@ -2762,10 +2762,10 @@ public:
     CephContext* cct, const std::string &path,
     bluestore_bdev_label_t *label, uint64_t disk_position = BDEV_LABEL_POSITION);
 private:
-  int _check_or_set_bdev_label(std::string path, uint64_t size, std::string desc,
+  int _check_or_set_bdev_label(const std::string& path, uint64_t size, std::string desc,
                               bool create);
   int _check_or_set_main_bdev_label(
-    std::string path,
+    const std::string& path,
     uint64_t size,
     bool create);
   static int _read_main_bdev_label(