]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/workunits/nvmeof/basic_tests.sh: Assert number of devices
authorVallari Agrawal <vallari.agrawal@ibm.com>
Wed, 20 Nov 2024 14:23:38 +0000 (19:53 +0530)
committerVallari Agrawal <vallari.agrawal@ibm.com>
Tue, 26 Nov 2024 08:11:02 +0000 (13:41 +0530)
Check number of devices connected after connect-all.
It should be equal to number of namespaces created.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
qa/workunits/nvmeof/basic_tests.sh

index dc6fd1669da9bc25d967b2f1a6ca2cf2bced1e6d..794353348b4e375e3867d05781eb4c24784f8c9d 100755 (executable)
@@ -38,8 +38,10 @@ disconnect_all() {
 connect_all() {
     sudo nvme connect-all --traddr=$NVMEOF_DEFAULT_GATEWAY_IP_ADDRESS --transport=tcp -l 3600
     sleep 5
-    output=$(sudo nvme list --output-format=json)
-    if ! echo "$output" | grep -q "$SPDK_CONTROLLER"; then
+    expected_devices_count=$1
+    actual_devices=$(sudo nvme list --output-format=json | grep -o "$SPDK_CONTROLLER" | wc -l) 
+    if [ "$actual_devices" -ne "$expected_devices_count" ]; then
+        sudo nvme list --output-format=json
         return 1
     fi
 }
@@ -72,11 +74,13 @@ test_run connect
 test_run list_subsys 1
 test_run disconnect_all
 test_run list_subsys 0
-test_run connect_all
+devices_count=$(( $NVMEOF_NAMESPACES_COUNT * $NVMEOF_SUBSYSTEMS_COUNT)) 
+test_run connect_all $devices_count
 gateways_count=$(( $(echo "$NVMEOF_GATEWAY_IP_ADDRESSES" | tr -cd ',' | wc -c) + 1 ))
 multipath_count=$(( $gateways_count * $NVMEOF_SUBSYSTEMS_COUNT)) 
 test_run list_subsys $multipath_count
 
 
+
 echo "-------------Test Summary-------------"
 echo "[nvmeof] All nvmeof basic tests passed!"